[Tiger-devel] Some patches before the release?

[Nicolas François]

Hi,

Sorry for not submitting them before.
I could only recently clean my workspace.

So here are some patches that may have some interest.

check_passwdspec_strict_user.diff
It remove a [pass19w] Login ID mail does not have password aging enabled,
which was caused by mail matching the mail and fetchmail users.

check_rhosts.diff
I'm not sure it should be applied, but seems logical to me.

lintian_checks.diff
lintian issue a warning for systems/HPUX/genpasswd and
systems/HPUX/check_passwdspec.
On Linux, bash needs "shopt -s extglob" to support +(...) in cases. I
don't have access to any HPUX system, so I don't know if it is a
problem. Can somebody check it and say if it should be ignored?

tiger_run_aide.diff
tripout was used instead of aideout

Tiger_TESTMODE.diff
Tiger_TESTMODE_indent.diff
I don't know if you want this one.
It is just that Tiger_TESTMODE can't be set to 'Y' after the first lines
of the script.
The second diff is just a re-indent of tiger after applying the first
one.


hth,

[Javier Fernández-Sanguino Peña]

Post by Nicolas François
Hi,
Sorry for not submitting them before.
I could only recently clean my workspace.

No problem.

Post by Nicolas François
So here are some patches that may have some interest.
check_passwdspec_strict_user.diff
It remove a [pass19w] Login ID mail does not have password aging enabled,
which was caused by mail matching the mail and fetchmail users.

Applied.

Post by Nicolas François
check_rhosts.diff
I'm not sure it should be applied, but seems logical to me.

Applied.

Post by Nicolas François
lintian_checks.diff
lintian issue a warning for systems/HPUX/genpasswd and
systems/HPUX/check_passwdspec.
On Linux, bash needs "shopt -s extglob" to support +(...) in cases. I
don't have access to any HPUX system, so I don't know if it is a
problem. Can somebody check it and say if it should be ignored?

I rather let the HPUX guys handle this.

Post by Nicolas François
tiger_run_aide.diff
tripout was used instead of aideout

Applied, thanks.

Post by Nicolas François
Tiger_TESTMODE.diff
Tiger_TESTMODE_indent.diff
I don't know if you want this one.
It is just that Tiger_TESTMODE can't be set to 'Y' after the first lines
of the script.
The second diff is just a re-indent of tiger after applying the first
one.

What's the rationale of the above change? I still have to review the patch
thoroughly to understand it so I have not included it yet...

Regards

Javier

[Nicolas François]

Post by Javier Fernández-Sanguino Peña

Post by Nicolas François
Tiger_TESTMODE.diff
Tiger_TESTMODE_indent.diff
I don't know if you want this one.
It is just that Tiger_TESTMODE can't be set to 'Y' after the first lines
of the script.
The second diff is just a re-indent of tiger after applying the first
one.

What's the rationale of the above change? I still have to review the patch
thoroughly to understand it so I have not included it yet...

Nothing really important, it removes dead code:

After the lines:
[ "$Tiger_TESTMODE" = 'Y' ] && {
exit 0
}

[ "$Tiger_TESTMODE" != 'Y' ]
is always true.


Kind Regards,